cashapp/wisp

RepeatedTask metric labels are incorrect

Closed this issue · 3 comments

looks like it's trying to add two labels to the metric, name and result. There are two problems here:

I've been trying to write a pull request that fixes this and adds tests that metrics are being recorded as expected, but I am having a very difficult time getting a usable metric registry in unit tests.

@chris-ryan-square Are there any examples of validating metrics in unit tests for wisp that I can follow?

Not that I am aware of - I think the only reference to metrics is in wisp-task