casper-ecosystem/casper-manager

Review

Closed this issue · 3 comments

KillianH commented

Need a quick review of the Continuous Delivery pipeline if you have some time : https://github.com/casper-ecosystem/casper-manager/blob/main/.github/workflows/CD.yml it will publish two libs : casper-manager the Snap itself, and casper-manager-helper a wrapper around Metamask RPC calls for ease of use and maintainability. Dunno if we need/want to scope those under a certain npm org ?

@hoffmannjan

hoffmannjan commented

Hi @KillianH , it looks good to me but I would follow the pattern that we use in all github repos - to publish on release being created. Other then that, we also need @sacherjj or somebody from SRE who will set NPM_TOKEN for this repo and we good :)

sacherjj commented

npm_token added.

KillianH commented

@hoffmannjan the packages uses the release-it software to create releases during the pipeline automatically with the changelog etc.