castorini/daam

Report a mistake(maybe)

SDaoer opened this issue · 1 comments

SDaoer commented

Thanks for your code. I am following your work, and I found a piece of confusing code that might be a mistake. It is in the file hook.py lines 103 and 104:
up_names = ['up'] * len(model.up_blocks)
down_names = ['down'] * len(model.up_blocks)
Shouldn't it probably be:
down_names = ['down'] * len(model.down_blocks)

daemon commented

Ah yeah, that's more robust for models without the same number of upsampling and downsampling blocks. I'll fix that soon.