update_boot_image does not cover non-master branches / edge cases well
Opened this issue · 0 comments
catb0t commented
the hot path for update_boot_image
/ _get_boot_image
is when branch
is master and there's an internet connection. the following output, from a different branch, demonstrates how useless it currently is
its logic needs to be entirely overhauled
** GET http://downloads.factorcode.org/images/reproducible-vm/checksums.txt ==> 404 Not Found
** GET http://downloads.factorcode.org/images/master/checksums.txt ==> 200 OK
update_boot_image: boot image sums: 380a22ac3b325b5675e7aecae99fa7f0 / 03fbcb9aa339ca129577a689544e3aaf
update_boot_image: !!! local / remote checksum mismatch !!!
_get_boot_image: Downloading boot image file boot.unix-x86.64.image
** GET http://downloads.factorcode.org/images/master/boot.unix-x86.64.image ==> 200 OK (1s)
** GET http://downloads.factorcode.org/images/master/checksums.txt ==> 200 OK
_get_boot_image: boot image sums: 380a22ac3b325b5675e7aecae99fa7f0 / 380a22ac3b325b5675e7aecae99fa7f0
multifactor/lib/shell_words.sm
Lines 293 to 316 in f44e5e2