catchorg/Clara

Compilation warning: ‘flag’ may be used uninitialized

aivarsk opened this issue · 1 comments

Compilation produces following warning:

./third_party/clara/clara.hpp: In member function ‘virtual clara::detail::ParserResult clara::detail::BoundFlagRefBase::setValue(const string&)’:
./third_party/clara/clara.hpp:686:24: warning: ‘flag’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                 setFlag( flag );
                 ~~~~~~~^~~~~~~~

I fixed it locally by initializing flag to false but there might be better ways to solve this.

I believe the offending code was fixed in 8e66435 (now part of v1.1.0), but then removed altogether in 5d21b7a.
So I'm going to close this one now. Thanks for raising.