cathugger/mkp224o

Show partial matches

Closed this issue · 5 comments

That seems like a pretty nice feature to me - always print the longest partial match found. Yes? No?

Additional logic for this will likely degrade performance. I'm thinking that no.

Curious, how does the algorithm work? Does it really search character by character, left to right? Or is it more or less random?

it depends on whether it's using intfilter or default binfilter. with intfilter, it uses integer sized masking and checking operations wholesale, while with binfilter it does byte-by-byte masking and checking.

currently it discards tens of millions of keys if not more for few successful key finds, and adding any sort of "longest partial match" state logic in that path would seriously mess with perf. maybe not in very large way but it definitely would be measurable

so yeah i won't be implementing this.