catppuccin/grub

Windows 11 icon request

dicktivity opened this issue · 5 comments

Hello, i have Ubuntu and Windows 11 dual boot.
Unfortunately there is no windows 11 icon, only the old windows icon in icons folder.
So i attempt to create windows 11 icon and manually add it to icons folder.
But the grub theme doesn't pick it up, there is no icon beside my Windows 11 entry menu.
I already matched the icon name and entry menu class "windows11"

My /etc/grub.d/40_custom file:

#!/bin/sh
exec tail -n +3 $0
# This file provides an easy way to add custom menu entries.  Simply type the
# menu entries you want to add after this comment.  Be careful not to change
# the 'exec tail' line above.
menuentry "Windows 11" --class windows11 {
   search --no-floppy --set=root --fs-uuid AA9F-2C38
   chainloader (${root})/EFI/Microsoft/Boot/bootmgfw.efi
}

menuentry "Reboot" --class restart {
        reboot
}

menuentry "Shut Down" --class shutdown {
        halt
}

windows11.png
windows11

My Grub:
Screenshot from 2022-12-29 13-46-13

What is the name of the class for windows in /boot/grub/grub.cfg?
I don't have windows on any of my computers but as I know it looks for the png with the name as it is in /boot/grub/grub.cfg.

Thanks for the reply elkrien.
The class in grub.cfg is the same as in /etc/grub.d/40_custom

-
-
-
### BEGIN /etc/grub.d/40_custom ###
# This file provides an easy way to add custom menu entries.  Simply type the
# menu entries you want to add after this comment.  Be careful not to change
# the 'exec tail' line above.
menuentry "Windows 11" --class windows11 {
   search --no-floppy --set=root --fs-uuid AA9F-2C38
   chainloader (${root})/EFI/Microsoft/Boot/bootmgfw.efi
}

menuentry "Reboot" --class restart {
	reboot
}

menuentry "Shut Down" --class shutdown {
	halt
}
### END /etc/grub.d/40_custom ###
-
-
-

I should add that i don't have this issue with distro-grub-theme.
Screenshot:
Screenshot from 2022-12-29 15-55-24

Do you think it's because the image (png) format? I create the windows 11 icon using Photopea .

Okay so i went back and just straight up copy the windows 11 icon from other theme and paste it to catppuccin theme and it worked.
I guess the issue is indeed the image format.
Will try another image editor later.

Screenshot from 2022-12-29 16-27-30

Great. How about a PR with new icon? If not could You attach icon file that works and I will upload it to this repo?

Alright just created a new PR.
I make the icon using corel draw this time and it worked.

Screenshot from 2022-12-29 20-43-35

Thank you for the response elkrien.
Closing this issue.