Welcome Screen: wrong project selection color
darkenmay opened this issue · 3 comments
Theme version: 2.0.9
Hello and first of all, thanks you so much for such amazing theme. Looks like I have found incorrect color on welcome screen which uses for a single project selection/highlighting/hovering. The investigation shows that IntelliJ uses lightSelectionBackground parameter from Table object instead of some in WelcomeScreen object. To fix this issue that parameter should be defined in main.ts file. Actually, I can create the fix on my end and then create a new pull request or it could be fixed by someone else. Currently, the question is more about which color should we use for selection/highlighting/hovering. I think there are few options: selectionBackground and secondaryBackground.
Let's decide.
current color
selectionBackground color
secondaryBackground color
Hiya 👋, thanks for reporting this in such great detail!
While selectionBackground makes the most sense, I actually think secondaryBackground looks best out of the two as it doesn't clash with the grey project name as much. It is also worth mentioning that it should look nice on all flavours so we may have to resort to using isLatte() checks along with the opacity function.
It'd be great if you want to raise a PR for this. I personally can't really promise when I'll be able to do it.
Hi,
I totally agree with you about secondaryBackground color and seems it would be the best to go with. Below are examples with secondaryBackground color for that case in all four flavours. If all of them are looking fine then I will go ahead and create a PR.
Latte
Frappe
Macchiato
Mocha
I think that's fine for the time being! A PR would be greatly appreciated.