caxanga334/cvreduxmodified

SourceBans vote evasion ban working intermittently

Closed this issue · 2 comments

Describe the bug
Vote evasion bans run through SourceBans do not seem to post a good percentage of the time.

To Reproduce
Steps to reproduce the behavior:

  1. Call vote on player
  2. Player disconnect
  3. Ban is only posted intermittently

Expected behavior
Custom Votes to ban players via SourceBans++.

Screenshots
N/A

Game Server

  • Sourcemod version 1.10-6380 & 1.9-6275
  • Metamod version 1.10.7-dev git 968
  • Custom Votes plugin version 1.16.2U-dev
  • SBPP Version 1.6.3
  • Game CS:GO

Additional context
The disconnect is properly logged, but the ban is not posted a good portion of the time, see:

L 02/03/2019 - 17:09:41: [Custom Votes] Vote Mute Player (Voice) started by user1 ( STEAM_1:0:x ) targeting user2 ( STEAM_1:0:xx ).
L 02/03/2019 - 17:09:44: [Custom Votes] Vote target disconnected while vote was in progress! The target was: user2 ( STEAM_1:0:xx ).
L 02/03/2019 - 17:30:49: [Custom Votes] Vote Mute Player (Voice) started by user1 ( STEAM_1:0:x ) targeting user2 ( STEAM_1:0:xx ).
L 02/03/2019 - 17:30:52: [Custom Votes] Vote target disconnected while vote was in progress! The target was: user2 ( STEAM_1:0:xx ).
L 02/03/2019 - 17:31:23: [Custom Votes] Vote Mute Player (Voice) started by user1 ( STEAM_1:0:x ) targeting user2 ( STEAM_1:0:xx ).
L 02/03/2019 - 17:31:29: [Custom Votes] Vote target disconnected while vote was in progress! The target was: user2 ( STEAM_1:0:xx ).

I vaguely remember this being an issue in another plugin that attempted to ban players after they disconnected - the user was disconnected before SourceBans could issue the ban. I tested using local banning, and it works 100% of the time.
Edit: Found it, and here's the issue opened with SBPP: sbpp/sourcebans-pp#267

I've tested on my TF2 server 10 times and this issue didn't happen.

Seems to have been an issue on my end, I've been running it without issue lately so I'll go ahead and close this out.