Adding new themes and skins to periscope's instantiation of shinyDashboardBody

[MaximilianLombardo]

Description
Hi,

This isn't necessarily a bug as I did some modification of the library that wasn't necessarily intended - maybe it is more of a feature request. I tried to some more complete re-skinning of a periscope shiny application. More specifically, I tried to use the dashboardthemes package. I did this by editing the periscope:::fw_create_body() function like so:

function ()
{
    app_info <- shiny::isolate(.g_opts$app_info)
    info_content <- NULL
    if (!is.null(app_info) && (class(app_info)[1] == "html")) {
        info_content <- shinyBS::bsModal(id = "titleinfobox",
            title = shiny::isolate(.g_opts$app_title), trigger = "titleinfobox_trigger",
            size = "large", app_info)
    }
    return(shinydashboard::dashboardBody(
dashboardthemes::shinyDashboardThemes("grey_dark"), #This is the new line that I added
        shiny::tags$head(shiny::tags$style(.framework_css()),
            shiny::tags$script(.framework_js())), info_content,
        shiny::isolate(.g_opts$body_elements), if (shiny::isolate(.g_opts$show_userlog)) {
            .bodyFooterOutput("footerId")
        } else {
            NULL
        }))
}

Behavior
This actually worked really well except for a white strip at the bottom of the app. Do you have any idea how I might be able to get rid of it? It is almost like there is a footer that is specified somewhere else and overriding the theme I am applying over it.

As a side note - perhaps it would be a good feature to add to the package for a little more customization?

Screenshots

[cb4ds]

Thank you for reaching out. The blank line at the bottom of the screen is not an issue with the theme, periscope, shiny or shinydashboard. It is a long-standing "oddity" of browser behavior, and I find that it shows up especially when there is not a lot of vertical content on the page in shiny applications. There is a lot of discussion going back 5+ years around the cause(s) of this on stack overflow, etc and it seems like the solution is always custom to the situation to get around it. Unfortunately without a consistent rhyme or reason that this happens it isn't something we plan to address.

Thank you for pointing out the dashboardthemes package - we will consider it for inclusion in future updates as it matures.