kobaltw in dist has DOS line ending in 1.0.49 release zip
Closed this issue · 3 comments
ethauvin commented
I could has sworn you made a test for that?
cbeust commented
No, I never did. The test that verifies the zip shape is VerifyKobaltZipTest, think you could add this?
ethauvin commented
Yep, I'll work on it.
mcarifio commented
Also appears in 1.0.125
mcarifio@shuttle:/opt/kobalt/kobalt-1.0.125/kobalt-1.0.125/bin$p ./kobaltw
/usr/bin/env: ‘sh\r’: No such file or directory
mcarifio@shuttle:/opt/kobalt/kobalt-1.0.125/kobalt-1.0.125/bin$p od -c kobaltw
0000000 # ! / u s r / b i n / e n v s
0000020 h \r \n \r \n c a s e " $ ( u n a
...Interestingly, github doesn't have \r\n line-endings, only \n:
curl --silent https://raw.githubusercontent.com/cbeust/kobalt/master/dist/kobaltw|od -c
0000000 # ! / u s r / b i n / e n v s
0000020 h \n \n c a s e " $ ( u n a m e
...so perhaps the line ending is introduced during packaging (i.e. making the zip file)? Hard to believe...