libp4est / libsc should have a proper SOVERSION

Question

libp4est / libsc should have a proper SOVERSION

StefanBruens opened this issue 2 years ago · 6 comments

StefanBruens commented 2 years ago

Description

Both libraries should have a SOVERSION which gets bumped every time the ABI is changed in an incompatible way.

Proposed solution

https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html

Answer 1 · 2023-01-27T14:06:00.000Z

Thanks; after I hook the latest libsc into p4est, this can be addressed.

Answer 2 · 2023-03-30T10:50:20.000Z

Is it actually intended to have a SOVERSION (ABI) bump on every patch version change?

This is not wrong per se, but will force everyone to rebuild/relink all dependent packages on each version change.

Answer 3 · 2023-03-30T10:57:59.000Z

I have just introduced -version-info to libtool at all. The production releases of p4est and libsc are at 2:0:0.

I'll try to update these numbers as infrequently as possible. This one change from 0:0:0 appears long overdue.

Do you have further comments on versioning and packaging?

Answer 4 · 2023-03-30T10:58:43.000Z

And, I have not changed anything in CMAke. I'll be happy to look at any contributions that align the versioning produced by CMake to the authoritative produced by autoconf/automake/libtool.

Answer 5 · 2023-03-30T11:10:43.000Z

The SOVERSION property should be the same as current - age.revision from the libtool versioning (i.e. 2.0 for 2:0:0).

Answer 6 · 2023-03-30T11:21:51.000Z

Would you like to add this properly to the libsc and p4est CMake files?