cburstedde/p4est

Valgrind errors

prj- opened this issue · 3 comments

prj- commented

Could you please merge changes from develop...tisaac:p4est:tisaac/petsc to make the code Valgrind-clean?

cburstedde commented

Thanks for the heads-up. We have made some of these changes on our side but are looking into it.

Hi @tim-griesbach, could you please check whether "master" can be merged cleanly into @tisaac's petsc branch?

tim-griesbach commented

I merged the current master branch into @tisaac's petsc branch and resolved the merge conflicts. The resulting branch is https://github.com/tim-griesbach/p4est/tree/petsc. Now, we could merge this branch into master with master...tim-griesbach:p4est:petsc as diff.

  • 👍1
cburstedde commented

Please @prj- check out #194. @tisaac, any remarks?

Note that we have a valgrind CI. Why did this not report the errors you see from petsc? Should the CI be tweaked?

I am also, purposefully, not initializing the p4est user data. This is the responsability of the user -- works ok?