cburstedde/p4est

Empty ghost for lnodes

cburstedde opened this issue · 2 comments

Description

The p4est_lnodes_new constructor currently requires a fully populated ghost layer.
The latest develop branch contains a p4est_ghost_new_local constructor that creates a ghost layer with zero elements. It can in theory be used to produce local-only numberings, for example, by pretending that a process has no parallel neighbors.

When passing this empty ghost layor to the lnodes constructor, the code runs into assertions since presently this behavior is out of spec. I'm wondering whether @tisaac may be in favor of making this variant work for p4est_lnodes_new.

As an aside, we now have the enum value P4EST_CONNECT_ALMOST (= CORNER - 1). Would it make sense to assert is_balanced with this value in lnodes_new?

I think this would not make sense after all. Even a purely local lnodes requires ghost information for the face code. Closing.