No way this can work
gregory opened this issue · 14 comments
The version in this package is 0.9.0 but has never been published to atmospher
Also, there package is trying to load src/subsCache.js but the filename is src/SubsCache.js
That plus the fact it's written in es5 and the package doesn't include ecmascript
I opened a PR #37 to fix it.
@gregory You are correct, atmosphere package is NOT updated, since component has been changed from Coffeescript to Javascript and we have not finished testing all functionality we use yet.
Will review pending testing as soon as as can, thanks for the PR.
@paranoico @ccorcos do you really have the time to maintain this repo? Seems not to be that big but this issue still remains!?
@jankapunkt Sorry, I have not time yet.
Coffescript version is still working correctly and published. We cannot release JS version yet to our mobile devices. There is a problem regarding offline data gathering and then restarting device, but do not know if we have to modify this component yet.
Ok, seems understandable. Is there a reason, why you can't add the tests to this repo? Maybe we can provide some support in testing and find the error.
Well, again our time in my side is the main reason. Currently we use also ground-db and cordova-plugin-kiosk among other plugins.
So I am pretty sure the error is gound and efforts here are in that directions, I will try to add some tests as u suggest next week.
If you can provide those PR via, it will be very welcome also.
I can provide some tests but I only some unit tests in mocha. Would that be an improvement?
I already wrote some unit tests with mocha and found some inconsistencies in a helper function. I will open a PR once I have completed tests for the all functions in the api.
Maybe I find some more things to fix which may also help you with your mobile issue
please see #39
Both PRs are merged now, my team and I will start testing next week on my side.
Sorry about my month and a half delay.
@jankapunkt The file src/SubsCache.js does not exists in current master branch, it seems you changed its name on your PR to src/subsCache.js back again. Am I right?
Yes I changed the Filename to the way, how it has been referenced in the package.js File.
I can fix that and open a new PR, please let me know, which naming you do prefer.
Please see #40
Good @jankapunkt , thanks, and I agree file should be named SubsCache since that was the initial name @ramezrafla used on his first JS version commit months ago.