Errors when running against numpy 1.16
elija-feigl opened this issue · 2 comments
The numpy 1.16.0 release fixes fromstring() issue that was exploited in the code.
numpy.rec.fromstring():
Arrays based off readonly buffers cannot be set writeable
We now disallow setting the writeable flag True on arrays created from fromstring(readonly-buffer).
from:
https://github.com/numpy/numpy/blob/master/doc/release/1.16.0-notes.rst
Thanks for pointing this out. I've updated mrcfile to indicate that it's not compatible with numpy 1.16 for now, and I'll try and fix it properly soon.
This is now fixed.
Other projects have also had similar problems, and it was very helpful to see their discussions while fixing this. For reference:
numpy/numpy#9440 - the numpy bug about not allowing writing to immutable buffers
numpy/numpy#11739 - the pull request that fixed numpy's behaviour and caused this problem for us
nipy/nibabel#697 - a very similar bug in the Nibabel project