cdnjs/polyfill-service

Will this project support `polyfill-library@4` and beyond?

mhassan1 opened this issue · 5 comments

mhassan1 commented

What

The original polyfill-service repository has many requests for missing polyfills; for example, polyfillpolyfill#2756, polyfillpolyfill#2744, and polyfillpolyfill#2734. All of the requested polyfills are available in polyfill-library@4.

Because this repository vendors the polyfills inside the polyfill-libraries directory, it is unclear where they came from and whether they will get updated.

Will this repository ever get additional polyfills from polyfill-library@4 and beyond? If so, which repository will those polyfills come from? See related conversation at JakeChampion/polyfill-library#1323.

xtuc commented

Note that the version 4.8.0 has been added to https://cdnjs.cloudflare.com/polyfill.

mustafa0x commented

Woah, finally, awesome, thanks so much Sven! (Odd that it's at v3/ instead of v4/, but that's of little concern.)

I assume this can be closed.

mhassan1 commented

@xtuc I'm assuming 4.8.0 came from https://www.npmjs.com/package/polyfill-library. Is that correct?

If that's correct, given that JakeChampion/polyfill-library#1323 has not gotten a response from the maintainer, you may want to consider getting future polyfill-library updates from https://www.npmjs.com/package/@mrhenry/polyfill-library, which is a maintained fork. FYI @romainmenke.

xtuc commented

@xtuc I'm assuming 4.8.0 came from https://www.npmjs.com/package/polyfill-library. Is that correct?

Yes, correct.

romainmenke commented

Thank you @xtuc 🙇

Odd that it's at v3/ instead of v4/, but that's of little concern.

If I recall correctly:

  • the hosted service has versioning for it's API (which query params are available, how do they work, ...)
  • the library has versioning for it's API (how does the library work, which polyfills are available, ...)

In v4 of the library we (massive effort by @mhassan1) dropped support for IE8.
But we didn't make changes to other parts of the public interface so this should be fine :)

Given the age of IE8 I don't even think this is breaking for those users who don't set a version string in their url.

you may want to consider getting future polyfill-library updates from https://www.npmjs.com/package/@mrhenry/polyfill-library, which is a maintained fork

We also took some extra measures:

  • no dependencies on packages still under control of the previous maintainer
  • all polyfills are vendored (and thus tracked by git)

https://github.com/mrhenry/polyfill-library/blob/main/CHANGELOG.md#v500

  • 👍2