cdonohue/pristine-ui

Tab bar too tall?

Closed this issue · 7 comments

Thanks for this cool theme :)

It seems that a recent version made the tabs a lot taller. Is this intended or bug? I'd much prefer the original - at least it'd be great if this can be optional.

Also the text doesn't seem to be vertically aligned in the tabs (too low).

I did push an update and modified the tab size, @danqing. Maybe this could be a setting for the theme and users can select if they want compact or more spacious tabs?

Yes, that'd be very welcomed :) I personally would love to stay with the old height.

Btw unrelated, the Choose a Theme page can use a bit more work :) The gear button can have a bit more padding left and the dropdown seems a little taller.

Thanks again for this great theme!

On second thought @danqing, I might just shrink the tabs a bit while also removing some padding. I'll post up some images here with the results. Also, thanks for the catch on the theme settings view!

I feel like these changes make the tabs a bit more compact, while also retaining a height that is larger than the original design.

screen shot 2017-07-25 at 2 49 04 pm

That looks nice :)

@danqing I'll also roll your theme settings fixes into this next patch update as well. Thanks again!

screen shot 2017-07-25 at 3 01 44 pm

@danqing these changes are live now