cduck/drawsvg

polish jupyterlablite integration

ChrisJefferson opened this issue · 1 comments

This isn't really an issue, more of an observation, but github doesn't really have a section for that?

I was playing with jupyterlab-lite (which runs entirely in the browser), and decided to see if drawsvg works. The answer is, (almost) everything works!

You can see it here: https://chrisjefferson.github.io/jupyterlite-test/lab/index.html

All I did was take the demo template ( https://github.com/jupyterlite/demo ), add drawsvg and hyperbolic, and add an ipynb so I could play. The only thing which doesn't seem to work is the DrawingWidget. Note it's quite slow loading at first, and i had to restart the kernel -- so it's not polished (but I think that's partly jupyterlab-lite), but I thought it was interesting to point out quite how much worked.

I don't expect you to work on this, but thought I could leave an issue, in case anyone else wanted to look, and maybe look into the bug (I might look, but for a while I might wait for more jupyerlab-lite development, which might end up fixing the bug for us).

cduck commented

I have enabled the "discussions" feature for this repo but I think this makes sense to post as an issue. My guess is the widgets don't work because it's Jupiter Lab, not specifically jupyterlab-lite. See #17.

I tried this recently at https://jupyter.org/try-jupyter/lab/ (you need to %pip install drawsvg) and didn't notice any significant performance issues.

I'll close this issue in favor of #17. Please reopen if you have any specific examples that perform poorly (and might be fixable given the limitations of jupyter lite).