cea-hpc/shine

Drop support of Python 2.4 and 2.5

Closed this issue · 2 comments

Clean Shine code, removing all code features which are not compatible with Python 2.6+, in order to start supporting Python 3 in the future.

  • except syntax (except Exception as exp)

  • drop has_key()

  • Replace 'type(...) is' with isinstance()

  • several methods now return an iterator instead of a list. This could easily trigger bugs, but hard to catch them.

  • Use proper raise syntax for exceptions

Potential optimizations (not mandatory for Python 3)

  • Use Python contexts (with statement)

First step is done in e151b96

I'm considering this ticket done. Let's have a dedicated ticket for Python 3 compat patches.