sorting scss files

Question

sorting scss files

abhijithvijayan opened this issue 6 years ago · 5 comments

abhijithvijayan commented 6 years ago

attaching numbers on names of scss files for easiness

Answer 1 · 2018-10-11T12:11:57.000Z

Apologies for being a pain on this project for you folks.

Could I question the number-in-name system for SCSS files? What are you aiming to achieve?

Answer 2 · 2018-10-11T13:09:38.000Z

I have just seen the change here and I am a little perplexed, I feel like the change from a semantic name to a section-1 is harmful rather than helpful, it will become less obvious which page you're working against.

Answer 3 · 2018-10-11T14:04:36.000Z

@Fedelaus
For the coming developments, the sections for each page will count up to a large number. So keeping it in an orderly manner like I did in PR avoids ambiguity.
I renamed every sectionId to section-number and renamed scss files accordingly.

Only till now the pages count to >20 sections.

Answer 4 · 2018-10-11T14:06:54.000Z

I don't know if i helps or not. But if it doesn't on the coming dev stage, I'll change it to the way it was, which I hope won't happen.

@Fedelaus We're also thinking of stopping accepting PR to the master branch directly. Do checkout that change in the PR
#194

Answer 5 · 2018-10-11T14:13:01.000Z

@Fedelaus Don't feel that way. We do love other's thoughts/ideas on the project and you're very welcomed to contribute as much as you feel the need to.