celestiaorg/blobstream-contracts

QGB: Differing Style in Use of state_eventNonce and state_lastValidatorSetCheckpoint

onurakpolat opened this issue · 0 comments

ID 020
Finding Differing Style in Use of state_eventNonce and state_lastValidatorSetCheckpoint
Severity Informational
Description Both of state_eventNonce and state_lastValidatorSetCheckpoint are used one time, however, state_eventNonce is sload’ed prior to use whereas state_lastValidatorSetCheckpoint is sload’ed when needed.
Recommendation Consider a consistent variable caching style performing both sloads at the beginning of the function.
Code References QuantumGravityBridge.sol#L317