Consider renaming namespace ID to namespace

Question

Consider renaming namespace ID to namespace

Opened this issue a year ago · 3 comments

Context

This library is used in celestia-app. After celestia-app/adr-014 and celestia-app/adr-015 were introduced, the namespaced data that gets pushed to an NMT consists of: namespace version (1 byte) | namespace ID (28 bytes) = namespace (29 bytes).

Problem

It is a bit confusing that this repo refers to them as namespace IDs when celestia-app refers to them as namespaces.

Proposal

Rename namespace ID to namespace in this repo

Answer 1 · 2023-06-27T21:36:49.000Z

A relevant comment #209 (comment)

Answer 2 · 2023-07-25T08:28:36.000Z

It would be really nice if we will rename a json representation too, bc in celestia-node we've already had a request to make pb and json definitions consistent

Answer 3 · 2024-04-26T17:24:03.000Z

I am unassigning myself from this issue due to other ongoing high-priority big block issues.