celestiaorg/nmt

extract `computeRoot` to a separate method

Opened this issue · 1 comments

rach-id commented 
          I think this was simpler because `computeRoot` also operates on a few vars inside of the scope of the wrapping method (e.g. `subtreeRoots`). I think this was an optimization wrt to the recursive calls. I would merge as is but if benchmarks and readability improve or stay the same, I would not mind Evan's suggestion in a followup PR.

Originally posted by @liamsi in #260 (comment)

rach-id commented

Also this: #260 (comment)