Return value of `setCell` isn't checked
rootulp opened this issue · 1 comments
rootulp commented
Context
rsmt2d/extendeddatacrossword_test.go
Line 209 in 2557620
Problem
After #172 setCell may return an error and indeed does when trying to overwrite a cell with nil. This means an error is going undetected in the test.
Proposal
Option A
Revert setCell to not perform input validation.
Option B
Check the the return value of setCell in the test. Fail the test if an error is observed.
Follow ups
rootulp commented
Based on the tests in extendeddatacrossword_test.go, the desired behavior is that setCell is able to overwrite cells with nil (see here)so going with Option A.