For long-lived grpc streaming messages, can we add parameters for ocgrpc to control the number of MessageEvents in a single span?

Question

For long-lived grpc streaming messages, can we add parameters for ocgrpc to control the number of MessageEvents in a single span?

chuerxiao opened this issue 6 years ago · 5 comments

Is your feature request related to a problem? Please describe.
dgraph-io/dgraph#3032

Describe the solution you'd like
We add parameters to ocgrpc to control the number of MessageEvents in a single span.
Describe alternatives you've considered

Additional context

Answer 1 · 2019-03-06T06:29:33.000Z

Sorry, I see that the latest version is already supported.

const (
	// DefaultMaxAnnotationEventsPerSpan is default max number of annotation events per span
	DefaultMaxAnnotationEventsPerSpan = 32

	// DefaultMaxMessageEventsPerSpan is default max number of message events per span
	DefaultMaxMessageEventsPerSpan = 128

	// DefaultMaxAttributesPerSpan is default max number of attributes per span
	DefaultMaxAttributesPerSpan = 32

	// DefaultMaxLinksPerSpan is default max number of links per span
	DefaultMaxLinksPerSpan = 32
)

Answer 2 · 2019-03-06T06:44:23.000Z

4baeb63 Add option to configure limits for attributes, annotations, message events and links. (#1015)

Answer 3 · 2019-03-06T17:27:10.000Z

@chuerxiao Does #1015 resolve your issue?

Answer 4 · 2019-03-07T17:02:29.000Z

Consider resolved, feel free to reopen if you have follow-up questions.

Answer 5 · 2019-03-19T03:15:40.000Z

We made the dgraph version using the latest opencensus version. The dgraph was run for about two weeks and did not find that the dgraph had a memory leak associated with the trace function.