Vendor Thrift and remove the corresponding dependency in go.mod.
songy23 opened this issue · 1 comments
songy23 commented
OpenCensus-Go 0.20.0 forces a requirement of Thrift 0.12, which doesn't work with a lot of projects that 1. don't use Go module and 2. vendor an incompatible version of Thrift (e.g Jaeger, TChannel, etc.). If a project depends on both OpenCensus 0.20.0 and Jaeger, and uses Go module, that project won't build.
One straightforward fix is to revert 3b8e272, though that commit solved problems for some other users and reverting it may cause problems again. For now we have a v0.19.3 release which is identical to v0.20.0 expect 3b8e272, but moving forward with 0.20+ releases we need to come up with a solution to this.
songy23 commented
Thrift will be removed from core in the next release.