census-instrumentation/opencensus-go

Zipkin exporter is missing bytes sent and received in message events

alexamies opened this issue · 2 comments

alexamies commented

Describe the bug
The trace.MessageEvent struct has a field for UncompressedByteSize:

https://godoc.org/go.opencensus.io/trace#MessageEvent

but those are not included in the Zipkin exporter

https://github.com/census-instrumentation/opencensus-go/blob/master/exporter/zipkin/zipkin.go#L184

To Reproduce
Need PR #1129 (#1129)

Steps to reproduce the behavior:

  1. Run the Go HTTP integration example
    https://opencensus.io/guides/http/go/net_http/server/

  2. Go to Zipkin
    http://localhost:9411/zipkin/

  3. Click on a span.
    As per the screenshot, all that is shown is 'SENT' or 'RECV'
    zipkin_no_bytes

Expected behavior
The number of bytes sent and received.

Additional context
These should be included and it is very important in determining why one trace might be taking longer than another trace. I submit a PR to fix the issue.

rghetia commented

zipkin exporter has its own repo now. So opened it there. census-ecosystem/opencensus-go-exporter-zipkin#6