Runmetrics: Expand to Include GC Stats

Question

Runmetrics: Expand to Include GC Stats

dm03514 opened this issue 5 years ago · 7 comments

Is your feature request related to a problem? Please describe.
Greetings! I just started using opencensus in go. The quality and framework was super easy to use, the primitives are intuitive and there are great docs! One thing I noticed was that runtime (runmetrics) metrics didn't include GC information. I'm wondering if runmetrics are a good place to include these metrics?

Describe the solution you'd like
If runmetrics is a good place to include these metrics, I was hoping to have gc stats included in the runtime metrics exported.

Describe alternatives you've considered
I could pretty easily instrument these in my own application, even package it as a library so all my go apps could easily get these metrics.

Additional context

This request is based on the runtime metrics that prometheus go client ships with.

Can see the prometheus metrics in action on their grafana dashboard:

Thank you!!!

Answer 1 · 2019-12-13T21:52:01.000Z

If you're open to this, I'd be happy to contribute it

Answer 2 · 2019-12-17T18:10:13.000Z

If you're open to this, I'd be happy to contribute it (will try and tackle it next week)

sure.

Answer 3 · 2021-02-11T10:52:06.000Z

Any idea when/if the pull request will be merged? The GC metrics are very useful to have.

Answer 4 · 2021-02-12T16:51:59.000Z

@hougaardj I just merged the PR. Are you able to test it out from the master branch, or do you need a tagged RC?

Answer 5 · 2021-02-15T12:42:02.000Z

Thank you for the quick turn around :)

I have tested it from master branch and i got the additional metrics. I do need a tagged release to start using it proper.

Answer 6 · 2021-02-23T20:10:49.000Z

@punya Can we create a release?

Answer 7 · 2021-02-24T16:53:06.000Z

@hougaardj we just published v0.23.0 (release notes).