GRPC Plugin Reports server/client CompletedRpcs to Latency Measure
smhendrickson opened this issue · 2 comments
smhendrickson commented
This can be found in master:
https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/client_metrics.go#L64
https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/server_metrics.go#L67
Smells like a typo? If so, I'm happy to provide a PR.
AIUI the process should be just adding a new stats var, and fixup tests:
https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/server_metrics.go#L25-L31
james-bebbington commented
Yes, this definitely looks like a typo. Please go ahead and create a PR if you need this to be fixed.
smhendrickson commented
Thanks James, I've sent a PR. we can go over the details there.