centralnicgroup-opensource/rtldev-middleware-whmcs

TLD Import & Pricing Sync - grace period price wrongly set

Remitur opened this issue · 3 comments

Describe the bug
Using TLD Import & Pricing Sync ( /admin/utilities/tools/tldsync/import ) grce period fee is wrongly set.
According to WHMCS, grace fee renewal and redemption fee renewal are sums that will be added to ordinary renewal fee.
So, i.e.:

  • standard renewal fee = 10
  • grace period renewal fee = 0 + 10
  • redemption period renewal fee = 100 + 10

Instead, in your price schema grace period renewal fee and redemption period renewal fee include also standard renewal fee.

So, i.e., currently in /admin/utilities/tools/tldsync/import your costs are reported so:
register 10
renew 10
transfer 10
grace 10
redemption 90

Instead should be:

register 10
renew 10
transfer 10
grace 0
redemption 80 (that's to say, 90-10)

@Remitur ispapi or cnic? or both?

For sure cnic (not already checked for ispapi, but I guess also ispapi is affected)

Thanks @Remitur for such bug reports. Very much appreciated.
-> v17.0.9