ceph/ceph-ansible

library/rados_user.py modify

karasjoh000 opened this issue · 9 comments

if not display_name:
display_name = name

If display_name != name and display_name is not provided as a param, then display_name is changed to name although the expectation will be that display_name should not change.

Note: I did not test this, but it seems that L268 and L269 need to be removed.

display_name is a mandatory parameter to radosgw-admin command. If you do not set the display_name, it fails creating the user with could not create user: unable to create user, no display name specified. This is probably why L268 and L269 are there for but indeed if the user already exists, its display_name will be overwritten with name.

Seems to be an easy fix, I will take a look at it. Thx

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Ill create a PR for this

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

guits commented

@karasjoh000 what is the status on this? should we take over?

This should be a 2 line fix I think.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.