cerebris/jsonapi-resources

Polymorphic Relationships Not Found On Aliased Resource

SingleShot opened this issue · 1 comments

This issue is a (choose one):

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • [] The feature I'm asking for is compliant with the JSON:API spec.

Description

We are using the v0-11-dev at risk.

If we define all that is necessary for a polymorphic relationship, we can include the related resources via something like GET /people/123?include=pets. Example code that works:

class PersonResource < JSONAPI::Resource
  relationship :pets, polymorphic: true, to: :many, polymorphic_types: %w[Cat Dog]
end

However if we "alias" the primary resource, the analogous request (GET /pet_owners/123?include=pets) does not find the related resources when we include the relationship:

  class PetOwnerResource < JSONAPI::Resource
    model_name 'Person'

    relationship :pets, polymorphic: true, to: :many, polymorphic_types: %w[Cat Dog]
end

It seems the related resource lookup is not taking into account that the primary/source resource might be aliased and using model_name.

Expected: the related resources are found.

Thanks @SingleShot, I'll take a look at it soon. I'm working on refactoring the query generation now so this is good timing.