cginternals/cmake-init

Drop GenerateExportHeader and WriteCompilerDetectionHeader

Tachi107 opened this issue · 2 comments

Tachi107 commented

GenerateExportHeader doesn't do anything special that can't already be known before building the project (i.e. a regular, static header file has no disadvantages over it), and it creates issues in MultiArch environments, as the generated export header is compiler dependant (related to #35). See zyantific/zycore-c#41 for an example.

WriteCompilerDetectionHeader already generates issues in cmake-init, as it isn't available in CMake versions older than 3.2; at the same time, the module got removed in CMake 3.20.

scheibel commented

Thanks for the suggestion.
I'm glad C++ and CMake evolved to get rid of those headers and I'm planning to remove the need for them.
Maybe we can get rid of pre-compiled feature headers altogether.

scheibel commented

Just for cross-reference: we encountered this issue before: cginternals/glbinding#333