chadbraunduin/backups-mode

Revert problem?

rsuhada opened this issue · 2 comments

Hi!

Thank you for the backups-mode. I think this is a great idea and improvement of the current system. I've setup everything and can see/diff the backup files for the current buffer. However if i hit R in order to revert to an old version of the file I get an error:

let*: Wrong type argument: stringp, nil

the file is not reverted and in my backup directory a new file is created, e.g.:

!Users!rs!tmp!tmp2.txt.3#temp#

if I try revert again I get:

let*: File already exists: /Users/rs/.emacs-backups/!Users!rs!tmp!tmp2.txt.3#temp#

(again no revert occurs)...

Do you have an idea what could be the problem? (Mac OS 10.6.8, Emacs 23.3 (9) if that helps...)

Also, is there an easy way to use ediff instead of plain diff?

Thanks in any case, I'll be using the mode for sure, I find it very useful an well done!

Thank you for bringing this bug to my attention. I developed backups-mode on a Linux machine so I never had this issue. Here's what I suggest for debugging it:

Run the revert command on a test file. When the error happens, in the debugger window, type "e" to evaluate a lisp form. Play around with evaluating the copy-file function using all the different optional arguments (http://www.gnu.org/software/emacs/elisp/html_node/Changing-Files.html). Once the #temp# file has been created you can also test copy-file from the scratch buffer. Perhaps, emacs on Mac requires an optional parameter that I am not supplying. I'm very interested in hearing about what you find.

Ediff can be launch from within a Diff buffer. Use C-c C-e. http://www.gnu.org/software/libtool/manual/emacs/Diff-Mode.html.

Thanks again,

Chad

Hi Chad,

thanks for the reply. I'll try to look into it as soon as I have some free time. I'm completely new to Emacs so not sure I'll manage to fix it, but at least I'll learn more about elisp. Thanks in any case for the nice work and if I manage to find a solution I'll let you know!

Cheers,
Robert