champcm/FPack-and-Funpack-for-Windows

Funpack can not process files with a "(" character in the filename or path

han-k59 opened this issue · 5 comments

han-k59 commented

Noted that funpack can not process files with a "(" character in the filename or path.

Maybe it is easy fix maybe not.

I have also send an email with a bug report to ccfits@heasarc.gsfc.nasa.gov

Han

han-k59 commented

I got this reply from heasarc.gsfc.nasa.gov

Hi Han,

I'm finding this bug is not just limited to Windows, but occurs on Linux as well. Thanks for reporting this and we'll look into a fix for a future release.

-Craig

champcm commented

Thanks for let me know for this issue, I will looking into it.

champcm commented

I look in to code the issue is come from cfileio.c there was an algorithm that check for '(', ')', '[', ']' must have closing bracket.

han-k59 commented

Thanks for updating the program to CFITSIO version 4.040. I had problems to compile it myself.

Question/remarks:

  1. Is the file cfitsio.exp required? The program runs without it The reason I'm asking because I distribute fpack/funpack with my program ASTAP and there is no need to distribute unnecessary file(s).

  2. A thing you could consider is to compile to a single file with the .dll files embedded (static libraries).

champcm commented
  1. I don't know but I just use a documentation of Cfitsio documentation for compile this executable.
  2. This project is follow Cfitsio CMakeBuilder, there is only have this option, not have embedded library option.