chaosvolt/cdda-arcana-mod

DDA Content Update Breaks / Changes Charge Using Comestibles

b3brodie opened this issue · 3 comments

b3brodie commented

Loading a world with Arcana installed yields the following error:

DEBUG : warnings for type red_black_vulnerary:
charges defined but can not have any

FUNCTION : check_definitions
FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item_factory.cpp
LINE : 2390
VERSION : f402277

Likely due to this change:
CleverRaven/Cataclysm-DDA#60885

chaosvolt commented

Oh that's cool, totally not going to break basically every mod and warrant lots of tweaks to items and itemgroups for reasons that boil down to nested containers still acting weird 3 years later...I'll work on it in a bit I guess.

EDIT: jfc the PR conversation is a gold mine of "this will very obviously cause many bugs and the PR OP has shrugged that off as not their problem" I can't wait to see what kinda issues are going to link to this PR.

  • 😕1
Snaaty commented

Yeah, really irritating to see people actively the gameplay experience and only refer to other people who are then supposed to finish the mess they started?
Anyway, thanks for your continued effort and your awesome mods, chaosvolt.

chaosvolt commented

Thanks, I'm gonna need to check the other mods I'm involved in maintaining in a bit but blargh, been busy a lot lately.

  • 👍1