Composer Doc is wrong in regards of `check` method
eugenet8k opened this issue · 0 comments
eugenet8k commented
The https://github.com/chaplinjs/chaplin/blob/master/docs/chaplin.composer.md#long-form says:
The check method should return true when it wishes the composition to be disposed and the compose method to be called.
But in reality https://github.com/chaplinjs/chaplin/blob/master/src/chaplin/composer.coffee#L126, it does the opposite:
# Apply the check method
if current and current.check composition.options
# Mark the current composition as not stale
current.stale false
else
# Remove the current composition and apply this one
current.dispose() if current