chaps-io/gush

Wrong workflow status after failed jobs

ferusinfo opened this issue · 6 comments

Currently if any jobs will fail (by throwing an exception in a job), the status of the workflow is not properly updated:

  • flow.status is returning :running
  • flow.failed? is returning false

Can you confirm this happens even after reloading the workflow as described here? https://github.com/chaps-io/gush#in-ruby

Yes, I can confirm that flow.reload isn't changing the status.

Alright, marking it as a bug and consulting my 🎱 to find the issue :D

Great to hear that, I will try to find it myself as well by reading the source.

@ferusinfo I pushed a fix and a spec for your case. Have a look at master :)

I will look into this later - but so far so good! 👍