Waw + Holem Sequence incorrect
Closed this issue · 1 comments
charlesLoder commented
v.1.1.2 introduced an issue where:
- בוֹ (bet + waw + holem) > bwo instead of bô
Problem strongly likely at:
// src/testEach.js
// line 41
// Tests for waw as a holem-mater
if (/wō(?!ǝ|ĕ|ă|ŏ|i|ē|e|a|ā|u|9)/.test(element)) {
if (/wō/.test(element)) {
element = changeElementSplit(element, /wō(?!ǝ|ĕ|ă|ŏ|i|ē|e|a|ā|u|9)/, 'ô');
// this is a workaround for lack of lookbehind support
let rev = [...element].reverse().reduce((a, c) => a + c);
if (/ōw(?!ǝ|ĕ|ă|ŏ|i|ē|e|a|ā|u|9)/.test(rev)) {
element = changeElementSplit(element, /wō/, 'ô');
}
}
Need to make more robust tests.
charlesLoder commented
Without dagesh - בוֹ (bet + waw + holem) - is correct as bô
With dagesh - בּוֹ (bet + dagesh + waw + holem) - is incorrect as bwō
But with dagesh as - בּוֹ (bet + dagesh + holem + waw) - is correct as bô