Links in level 1 headings are hard to read with the default (dark?) palette
spenserblack opened this issue · 6 comments
I originally raised this issue at cli/cli, but since they use glamour and don't customize the color palette it was recommended to raise the issue here.
When a level 1 heading contains a link, the purple-ish background and the dark cyan foreground of the link result in a low contrast that makes the text hard to read.
Here is a screenshot: cli/cli#6351 (comment)
Agreed, this doesn't look nice. We should probably skip the link styling within headings.
I just opened an issue in the glow repo (which can be seen above this comment) related to this.
@meowgorithm suggested using 123 for the foreground of links. I think that's a great idea, but looking at the screenshot it seems that the background clashes with the text before the URL as well. Maybe the background color should be changed instead?
In that issue I also suggested fixing it in the glow repo but this seems like a better place, since it is the root cause. If it's okay, I would like to fix this. Let me know what colors you decide on.
Is this problem specific to the dark theme?
Actually, I think it is both the dark and light theme. I've attached screenshots below. I might suggest doing something similar to the Dracula theme and possibly not having a background color. I was planning on fixing this after a color was decided on.
@brendencallahan Alright, thanks. I made a PR but I’ll edit it to include the other themes. Also, what terminal / shell theme are you using? Looks really nice :-)
@brandon-devs I see your pr now. Nice! Terminal is kitty with 0.9 opacity and #2d2c35 background and Jetbrains mono font. Shell is zsh with powerlevel10k theme.