chasinglogic/licensure

`check` does not seem to work on 0.4.0

Closed this issue · 6 comments

mdwn commented

Against my repo: https://github.com/mdwn/mtrack

Using licensure 0.3.2:

➜  mtrack git:(release-v0.1.3) licensure --check -p
➜  mtrack git:(release-v0.1.3) licensure -V
licensure 0.3.2

Using licensure 0.4.0:

➜  mtrack git:(release-v0.1.3) cargo install licensure
Replaced package `licensure v0.3.2` with `licensure v0.4.0` (executable `licensure`)
➜  mtrack git:(release-v0.1.3) licensure --check -p   
The following files were not licensed with the given config.
src/audio.rs
src/audio/cpal.rs
src/audio/mock.rs
src/config.rs
src/config/controller.rs
src/config/midi.rs
src/config/player.rs
src/config/playlist.rs
src/config/song.rs
src/config/track.rs
src/config/trackmappings.rs
src/controller.rs
src/controller/keyboard.rs
src/controller/midi.rs
src/main.rs
src/midi.rs
src/midi/midir.rs
src/midi/mock.rs
src/player.rs
src/playlist.rs
src/playsync.rs
src/songs.rs
src/test.rs

I've attempted to update the licenses, but there's no diff:

➜  mtrack git:(release-v0.1.3) licensure -ip
➜  mtrack git:(release-v0.1.3) git status
On branch release-v0.1.3
Your branch is up to date with 'origin/release-v0.1.3'.

nothing to commit, working tree clean
gpwclark commented

Having the same problem. Besides the failing linux build no clues. Going to check out and do some digging real quick. Love the tool and super thankful for an update!

  • 👍1
hcldan commented

I am also seeing this.

mdwn commented

I believe this is related to this PR: #35, in particular this change here: https://github.com/chasinglogic/licensure/blob/master/src/licensure.rs#L51. The call to add_license_header returns None if the license is already present, which inadvertently indicates that it needs to be updated. cc @chasinglogic

chasinglogic commented

Fix in PR here: #37

Once CI passes I'll get that merged and fix the linux build

chasinglogic commented

Hey all,

I've merged and released this fix to crates and github as 0.4.1. I've tested it myself but would appreciate if you could give it a whirl @mdwn and if your issue is fixed close the ticket.

mdwn commented

Running locally, looks like this is fixed for me:

➜  mtrack git:(dmx) ✗ licensure --check -p
➜  mtrack git:(dmx) ✗

Thank you for fixing this so quickly!

  • 👍1
  • 🎉1