chaynHQ/bloom-backend

Replace use of req["user"] with req["userEntity"] in subscription-user.controller.ts

Closed this issue · 4 comments

eleanorreem commented

Overview

Take a read through the umbrella ticket. As a sub task to this ticket we want to phase out the use of req["user"] from the subscription-user.controller.ts. The endpoints that need addressing are POST /subscription-user/whatsapp, POST /subscription-user/whatsapp/:id. Note that we haven't followed rest patterns here and hopefully this will be refactored at a later date but not part of this ticket.

Action Items

  • For each endpoint that uses req["user"], the service methods will need to be refactored to take the req["userEntity"] rather than req["user"]. This means the service methods will be taking userEntity rather than GetUserDto as its argument. The types need to be updated in the service method and adjustments will need to be made if they are used elsewhere.
  • Run all tests. This includes Cypress tests. You will need to load the frontend repository to get instructions about how this works. https://github.com/chaynHQ/bloom-frontend
ckirby19 commented

I would like to pick up this ticket please, thank you! :)

github-actions commented

Thank you @ckirby19 you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

ckirby19 commented

Can I just check if any more work is needed for this ticket?

eleanorreem commented

All good! Forgot to close this ticket!