chaynHQ/bloom-frontend

App Router Migration - Root Layout

Opened this issue · 7 comments

boodland commented

Sub issue of #702

App router uses a Root layout which is defined at the top of the app directory and applies to all routes. We need to migrate the contents of _app.tsx and _document.tsx to the root layout so they are applied for the app route.

Due to the complexity of the _app.tsx and _document.tsx files, the migration will be done according to the following steps as discussed in #1064:

  1. Creating the app directory and basic root layout with public testing page #1085
  2. Add Newrelic configuration #1086
  3. Add GoogleTagManager script #1117
  4. Add Rollbar script #1118
  5. Add OpenGraph Metadata #1120
  6. Add ErrorBoundary component #1121
  7. Add Material UI configuration #1122
  8. Add Analytics configuration #1123

Step one will be the parent PR/branch where the rest of the steps will be created from and merged to, once all the steps are completed and merged the PR/branch can be merged within dev branch.

Store Provider, i18n, Shell layout, Crisp script, AuthGuard and pages migration will be tackled in another parent PR as discussed in #1064 due to conflict with pages router and/or dependencies on i18n.

Until all pages are migrated and _app.tsx and _document.tsx files are removed any changes in any of the logic migrated to the app router needs to be changed accordingly for the app router version as well.

boodland commented

@kyleecodes, @eleanorreem or @annarhughes could you assign it to me please? Mentioning all of you so you are all aware of the state of the task.

github-actions commented

Thank you @boodland you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

eleanorreem commented

@boodland is this ticket just waiting on the newRelic configuration?

boodland commented

Hi @eleanorreem, yes that's correct. The discussion was to merge it within development once is finished and start working in the last set of task of the migration in another new brand branch. Nothing should be implemented by the time I start with the last part as discussed in #1064 until it is done and merged.

boodland commented

@eleanorreem and @kyleecodes let me know when this branch is merged within develop and a new epic/parent branch is created to tackle the last part of the migration, the sooner the better if possible. Thanks!

eleanorreem commented

@boodland Sorry I thought I had tagged you. The parent branch at the moment is failing 😢 so I haven't merged it yet. I've rebased so it is up to date with develop. Let me know if you still have capacity to work on this as I know its been taking a while to get it moving. Its a big project!

boodland commented

@boodland Sorry I thought I had tagged you. The parent branch at the moment is failing 😢 so I haven't merged it yet. I've rebased so it is up to date with develop. Let me know if you still have capacity to work on this as I know its been taking a while to get it moving. Its a big project!

Hi @eleanorreem, yeah!! it is a big project but we are closer to finish it than before 💪. I had just the last interview with a company and my capacity could change soon, we could create another parent branch from this one as it has been rebased to tackle the last stage so I can carry on creating subtasks before it is too late for me to contribute. If so, please let it know to @kyleecodes so she can create the branch.