checkout/checkout-woocommerce-plugin

Using $order->payment_complete($transaction_id) instead of update_post_meta...

valmedia opened this issue · 1 comments

valmedia commented

Hi,

Using $order->payment_complete($transaction_id) is the correct way to to set an order to "processing" and reduce stock. This will make it more compatible with Woocommerce and other plugins.

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-cards.php

Line 391 in b6315e5

update_post_meta( $order_id, '_transaction_id', $result['action_id'] );

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-cards.php

Line 491 in b6315e5

update_post_meta($order_id, '_transaction_id', $action['0']['id']);

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-cards.php

Line 495 in b6315e5

update_post_meta($order_id, '_transaction_id', $result['id']);

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-webhook.php

Line 143 in da4ae44

update_post_meta($order_id, '_transaction_id', $action_id);

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/apms/class-wc-checkoutcom-fawry.php

Line 74 in da4ae44

update_post_meta($order_id, '_transaction_id', $result['id']);

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-alternative-payments.php

Line 102 in da4ae44

update_post_meta( $order_id, '_transaction_id', $result['action_id'] );

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/apms/class-wc-checkoutcom-sepa.php

Line 118 in da4ae44

update_post_meta( $order_id, '_transaction_id', $result['id'] );

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-google-pay.php

Line 323 in da4ae44

update_post_meta($order_id, '_transaction_id', $result['action_id']);

checkout-woocommerce-plugin/woocommerce-gateway-checkout-com/includes/class-wc-gateway-checkout-com-apple-pay.php

Line 549 in da4ae44

update_post_meta( $order_id, '_transaction_id', $result['action_id'] );

Might have miss some but these should be updated to using $order->payment_complete($transaction_id).

Thanks

valmedia commented

Hi, any update on fixing your plugin with this?