checkout/frames-react

FramesLanguages type does not list all supported languages

Closed this issue · 1 comments

In types : checkout/frames-react/src/frames/types/types.tsx the FramesLanguages type states the languages are

export type FramesLanguages = 'EN-GB' | 'ES-ES' | 'FR-FR' | 'DE-DE' | 'KR-KR' | 'IT-IT' | 'NL-NL';

but according to the Get started with Frames

the available languages that one can use are

Arabic = AR
Chinese Simplified = ZH-CH
Chinese Traditional (Hong Kong) = ZH-HK
Chinese Traditional (Taiwan) = ZH-TW
Danish = DA-DK
Dutch = NL-NL
English = EN-GB
Filipino = FIL-PH
Finnish - FI-FI
French = FR-FR
German = DE-DE
Hindi = HI-IN
Indonesian = ID-ID
Italian = IT-IT
Japanese = JA-JP
Korean = KO-KR
Malay = MS-MY
Norwegian Bokmål = NB-NO
Spanish = ES-ES
Swedish = SV-SE
Thai = TH-TH
Vietnamese = VI-VN

I've tried passing in the SV-SE for example and got the correct localization in the frames fields, so I think only change needed is to extend the type.

This has been fixed in #58 and release in version 1.1.2.