Can we block a PR from being merged if any commits are still unsigned?
robbkidd opened this issue · 3 comments
robbkidd commented
The green, candy-like Merge button is enabled if the latest commit in a PR has a sign-off no matter how many prior commits there many be that are not signed-off. The prior unsigned-off commits will have their red-Xs, but checking that those red-Xs are from the DCO check and not previous failed CI runs is left up to a human.
An example: poboy/paprika#1
Some ideas:
- mark a PR as unmergeable directly despite the latest commit passing checks (like the future REST API endpoint for creating a Review that "requests changes")
- apply a label, e.g. "Some Commits Need Sign-Off"
- add a comment to the PR about some commits needing sign-off and link to them (this would/could be a bit like Curry's old behavior)
robbkidd commented
It looks like a REST API for the new PR Review feature is on the near-term roadmap. With that implemented, DCOBot could submit a "Request Changes" review when it notices any unsigned commits in a PR.
thommay commented
that'd be pretty delightful.