Telescope compatible

Question

Telescope compatible

reefki opened this issue 6 years ago · 4 comments

I just recently installed Telescope and got an error when inserting belongsToMany relation.

get_class() expects parameter 1 to be object, string given

Stacktrace:

../vendor/laravel/telescope/src/Watchers/ModelWatcher.php:35
--
../vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:357
../vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:209
../vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:169
../vendor/chelout/laravel-relationship-events/src/Concerns/HasBelongsToManyEvents.php:187
../vendor/chelout/laravel-relationship-events/src/BelongsToMany.php:47

Is there any chance to get this package compatible with telescope?

Answer 1 · 2018-10-30T18:46:52.000Z

Need time to work it out.

Answer 2 · 2018-10-30T19:04:49.000Z

I think it's because of the first parameter on HasBelongsToManyEvents events is the relation name. Not sure but it looks like this order should work: ($parent, $relation, $ids, $attributes)

Answer 3 · 2018-10-30T20:37:37.000Z

Yes, that looks correct, but i have to investigate a little further.

Answer 4 · 2018-11-06T11:16:32.000Z

Ok, this bug was fixed in laravel/telescope#284
Maybe we still need to change order of params.