configure.ac is out of sync, some gcc checks are missing
1ras opened this issue · 2 comments
configure.ac is out of sync, the gcc newer than 4.8 and gcc 10 checks are missing. They have only been added to configure, but not to configure.ac. When autoconf is used, the resulting configure script does not support gcc 10 and newer.
The related changes are part of commit 8c4bc2d
Not familiar with compiling. Can a patch be provided?
I took a closer look and I don't think its even necessary to check the gcc versions. It should be sufficient to check if the function flags -fgnu89-inline and -fcommon are supported by gcc, similar like -fno-stack-protector and -fno-reorder-functions are checked by configure.ac.
On the other hand -fgnu89-inline is supported since gcc 4.2 and -fcommon since gcc 4.4 (according to the old online documentation). It should actually be sufficient to add both to STAGE2_CFLAGS without further checks. Or is there a reason to support older versions?