electron-react-boilerplate/electron-react-boilerplate

Firing redux actions from the application menu

slightlytyler opened this issue · 8 comments

slightlytyler commented

What's the preferred way of hooking the application menu into redux? I've implemented undo / redo but am having trouble firing the actions from the menu click. It would be nice to have an example of this included in the repo

jhen0409 commented

We can use ipc to do it.
Also, if we done #108, it may become easier. :)

slightlytyler commented

@jhen0409 I am interested in #108 however I would like to see the starter include an example of how to accomplish it without redux-electron-store.

In my app I created a function bindStoreToMenu that is called when the store is configured. Also created a middleware undoRedoMenuState to properly set the enabled boolean for the menu items.

https://github.com/slightlytyler/mocksy/blob/master/app/store/bindStoreToMenu.js
https://github.com/slightlytyler/mocksy/blob/master/app/store/undoRedoMenuState.js

Any feedback on my logic is welcome, I'll gladly contribute what I can if this is something the project would like to include

amilajack commented

@burkhardr is it possible to do this with electron-redux?

burkhardr commented

@amilajack Yeah, couldn't see why not!

  • 🎉1
amilajack commented

Great! Closing this in favor of #968.

wandonye commented

Can anyone explain a little bit how this is done with electron-redux? Do I need to create a container for MenuBuilder just like other components?

wandonye commented

ok, looks like #1615 is the answer for me

wandonye commented

never mind, this stackoverflow solution is the simplest. I tried electron-redux, but in my case it creates some weird sync problem.

  • 👍2